Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Phone dropdown field has extra width #6866

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

harshit078
Copy link
Contributor

Description

This PR solves the issue #6865

Current Behaviour

Screenshot 2024-09-03 at 2 04 55 AM

Expected behavior

Screenshot 2024-09-03 at 2 05 46 AM

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR addresses the issue of extra width in the phone dropdown field within the activity tab by modifying the DropdownMenu component.

  • Modified DropdownMenu.tsx to add position: absolute and overflow: visible to the styled component
  • Changes aim to fix layout issues and prevent unwanted expansion of the dropdown menu
  • Affects the phone country picker dropdown in the activity tab
  • Improves UI consistency by aligning dropdown width with the input field

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@harshit078 harshit078 closed this Sep 2, 2024
@harshit078 harshit078 reopened this Sep 3, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

This PR addresses the issue of extra width in the phone dropdown field by modifying the DropdownMenu component in DropdownMenu.tsx.

  • Removed position: absolute and overflow: visible from the StyledDropdownMenu component
  • Added max-width: 200px to constrain the dropdown menu's width
  • These changes should prevent the dropdown from extending beyond the desired size
  • The modification directly impacts the PhoneCountryPickerDropdownSelect component
  • It's important to verify that these changes don't negatively affect other dropdown menus in the application

1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

@Bonapara
Copy link
Member

Bonapara commented Sep 3, 2024

Hi @harshit078, thanks for noticing this one! Can you make the picker as large as the input?

I've created another issue to improve the detail page inputs style: #6870

@harshit078
Copy link
Contributor Author

Sure @Bonapara , will do that

@martmull martmull self-assigned this Sep 5, 2024
Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it is not enough, we have the issue on currency picker also, the issue comes from https://github.com/twentyhq/twenty/pull/6166/files

@harshit078
Copy link
Contributor Author

Hi @martmull, Is the ARR field currency picker that you are referring too ?

Screenshot 2024-09-05 at 2 56 26 PM

@martmull
Copy link
Contributor

martmull commented Sep 5, 2024

@harshit078 yes, the input is too large also

@harshit078
Copy link
Contributor Author

Yes, This issue is already referenced under #6870 and I have already created an PR for this #6899.

@harshit078
Copy link
Contributor Author

Since this issue comes under the existing #6870 hence it wouldn't require max-width component and only width=auto will work.

Copy link
Contributor

@bosiraphael bosiraphael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @harshit078 for your contribution.

@bosiraphael bosiraphael merged commit 7c90e71 into twentyhq:main Sep 24, 2024
10 of 11 checks passed
Copy link

Thanks @harshit078 for your contribution!
This marks your 15th PR on the repo. You're top 2% of all our contributors 🎉
See contributor page - Share on LinkedIn - Share on Twitter

Contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants