-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Phone dropdown field has extra width #6866
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR addresses the issue of extra width in the phone dropdown field within the activity tab by modifying the DropdownMenu component.
- Modified
DropdownMenu.tsx
to addposition: absolute
andoverflow: visible
to the styled component - Changes aim to fix layout issues and prevent unwanted expansion of the dropdown menu
- Affects the phone country picker dropdown in the activity tab
- Improves UI consistency by aligning dropdown width with the input field
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
This PR addresses the issue of extra width in the phone dropdown field by modifying the DropdownMenu component in DropdownMenu.tsx
.
- Removed
position: absolute
andoverflow: visible
from the StyledDropdownMenu component - Added
max-width: 200px
to constrain the dropdown menu's width - These changes should prevent the dropdown from extending beyond the desired size
- The modification directly impacts the PhoneCountryPickerDropdownSelect component
- It's important to verify that these changes don't negatively affect other dropdown menus in the application
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenu.tsx
Outdated
Show resolved
Hide resolved
Hi @harshit078, thanks for noticing this one! Can you make the picker as large as the input? I've created another issue to improve the detail page inputs style: #6870 |
Sure @Bonapara , will do that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think it is not enough, we have the issue on currency picker also, the issue comes from https://github.com/twentyhq/twenty/pull/6166/files
Hi @martmull, Is the ARR field currency picker that you are referring too ? |
@harshit078 yes, the input is too large also |
Since this issue comes under the existing #6870 hence it wouldn't require |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @harshit078 for your contribution.
Thanks @harshit078 for your contribution! |
Description
This PR solves the issue #6865
Current Behaviour
Expected behavior