-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing creators data to webhook (#6726) #6749
fix: add missing creators data to webhook (#6726) #6749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses the issue of missing creator's data in webhooks by adding the creator's first name and last name to the webhook payload. Key changes include:
- Modified
CallWebhookJobsJob
to includecreatorDetails
in the job data - Updated
CallWebhookJob
to incorporatecreatorDetails
in the webhook payload - Enhanced
WorkspaceQueryRunnerService
to pass creator information when triggering webhooks - Added
creatorDetails
withfirstName
andlastName
to theCallWebhookJobData
type - Improved webhook payload completeness by including creator information for better tracking and auditing
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
…thub.com/naineel1209/twenty into fix/add-missing-creators-data-to-webhook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
No major changes found since last review.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
...es/twenty-server/src/engine/api/graphql/workspace-query-runner/jobs/call-webhook-jobs.job.ts
Show resolved
Hide resolved
Hi @naineel1209 thanks for your contribution! However there is already a createdBy field added a few weeks ago that contains that data and that should already be exposed in the webhook. |
Issue
Closes (#6726)
Description
This PR addresses the issue where the creator's details were absent from the webhook's payload. It now includes the
firstName
andlastName
of the creator in the payload.