Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing creators data to webhook (#6726) #6749

Conversation

naineel1209
Copy link
Contributor

Issue

Closes (#6726)

Description

This PR addresses the issue where the creator's details were absent from the webhook's payload. It now includes the firstName and lastName of the creator in the payload.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses the issue of missing creator's data in webhooks by adding the creator's first name and last name to the webhook payload. Key changes include:

  • Modified CallWebhookJobsJob to include creatorDetails in the job data
  • Updated CallWebhookJob to incorporate creatorDetails in the webhook payload
  • Enhanced WorkspaceQueryRunnerService to pass creator information when triggering webhooks
  • Added creatorDetails with firstName and lastName to the CallWebhookJobData type
  • Improved webhook payload completeness by including creator information for better tracking and auditing

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@naineel1209 naineel1209 marked this pull request as draft August 27, 2024 11:04
@naineel1209 naineel1209 marked this pull request as ready for review August 27, 2024 12:02
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

No major changes found since last review.

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings

@charlesBochet charlesBochet assigned Weiko and unassigned charlesBochet Sep 2, 2024
@Weiko
Copy link
Member

Weiko commented Sep 3, 2024

Hi @naineel1209 thanks for your contribution! However there is already a createdBy field added a few weeks ago that contains that data and that should already be exposed in the webhook.
Closing this issue, feel free to reopen an issue if you don't see it on your side

Screenshot 2024-09-03 at 17 29 08

@Weiko Weiko closed this Sep 3, 2024
@naineel1209 naineel1209 deleted the fix/add-missing-creators-data-to-webhook branch September 10, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants