Introduce remote table entity #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weiko
reviewed
Apr 16, 2024
| } from 'src/engine/metadata-modules/remote-server/remote-server.entity'; | ||
|
|
||
| @Entity('remoteTable') | ||
| @ObjectType('RemoteTable') |
There was a problem hiding this comment.
You don't want ObjectType here, your graphql type is already defined in your dto
|
|
||
| const localTableName = getRemoteTableLocalName(input.name); | ||
|
|
||
| this.validateTableNameDoesNotExists( |
| @@ -104,13 +106,76 @@ export class RemoteTableService { | |||
| throw new NotFoundException('Remote server does not exist'); | |||
| } | |||
|
|
|||
| const remoteTable = await this.createForeignTableAndMetadata( | |||
| if (!input.schema) { | |||
There was a problem hiding this comment.
Let's save one query by checking this earlier! 😄
...twenty-server/src/engine/metadata-modules/remote-server/remote-table/remote-table.service.ts
Show resolved
Hide resolved
thomtrp
force-pushed
the
tt-introduce-remote-table-objects
branch
from
95601d3 to
2971e62
Compare
charlesBochet
approved these changes
Apr 17, 2024
arnavsaxena17
pushed a commit
to arnavsaxena17/twenty
that referenced
this pull request
Oct 6, 2024
We will require remote table entity to map distant table name and local foreign table name. Introducing the entity: - new source of truth to know if a table is sync or not - created synchronously at the same time as metadata and foreign table Adding a few more changes: - exception rather than errors so the user can see these - `pluralize` library that will allow to stop adding `Remote` suffix on names --------- Co-authored-by: Thomas Trompette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will require remote table entity to map distant table name and local foreign table name.
Introducing the entity:
Adding a few more changes:
pluralizelibrary that will allow to stop addingRemotesuffix on names