-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4810 display participants in the right drawer of the calendar event #4896
4810 display participants in the right drawer of the calendar event #4896
Conversation
…r-of-the-calendar-event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work!
I've left comments!
Could we add stories on all these components?
packages/twenty-front/src/modules/activities/components/ExpandableList/ExpandableList.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/activities/components/ExpandableList/ExpandableList.tsx
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,109 @@ | |||
import React, { ReactElement, useState } from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move it to ui or nobody will find it! We are missing a story on this component too :)
packages/twenty-front/src/modules/activities/components/ExpandableList/ExpandableList.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/activities/components/ExpandableList/ExpandableList.tsx
Outdated
Show resolved
Hide resolved
import React from 'react'; | ||
import { useInView } from 'react-intersection-observer'; | ||
|
||
export const IntersectionObserverWrapper = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit worried about performances here to be honnest. Having one on the page is fined. Having many will impact the performance. I don't see a workaround. It looks like we need:
- this ExpandableList component or the one that has been forced to 2 chips for ActivityTarget
- an expandableList for table view that do not care about the intersection observer and is hiding the overflow with CSS without computing anything
I would love to discuss this with Design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...wenty-front/src/modules/activities/components/ExpandableList/IntersectionObserverWrapper.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/activities/components/ParticipantChip.tsx
Show resolved
Hide resolved
variant === 'bold' ? theme.font.weight.medium : theme.font.weight.regular}; | ||
`; | ||
|
||
export const ParticipantChip = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be abstracted (not necessarily in this PR) to a regular chip? Feels weird to have something specific for Participant
packages/twenty-front/src/modules/ui/layout/dropdown/components/DropdownMenu.tsx
Show resolved
Hide resolved
…r-of-the-calendar-event
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I still think we could add more stories but we can create issues for that!
…wentyhq#4896) Closes twentyhq#4810 - Introduces a new component `ExpandableList` which uses intersection observers to display the maximum number of elements possible
Closes #4810
ExpandableList
which uses intersection observers to display the maximum number of elements possible