refactor(front): remove getFieldSlug function

twentyhq · Jan 7, 2025 · c413ee1 · c413ee1
1 parent e497870
commit c413ee1
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 20 deletions.
diff --git a/packages/twenty-front/src/modules/object-metadata/utils/__tests__/getFieldSlug.test.ts b/packages/twenty-front/src/modules/object-metadata/utils/__tests__/getFieldSlug.test.ts
diff --git a/packages/twenty-front/src/modules/object-metadata/utils/getFieldSlug.ts b/packages/twenty-front/src/modules/object-metadata/utils/getFieldSlug.ts
diff --git a/packages/twenty-front/src/modules/object-record/record-group/hooks/useRecordGroupActions.ts b/packages/twenty-front/src/modules/object-record/record-group/hooks/useRecordGroupActions.ts
@@ -1,5 +1,4 @@
 import { useObjectMetadataItem } from '@/object-metadata/hooks/useObjectMetadataItem';
-import { getFieldSlug } from '@/object-metadata/utils/getFieldSlug';
 import { RecordBoardColumnContext } from '@/object-record/record-board/record-board-column/contexts/RecordBoardColumnContext';
 import { useRecordGroupVisibility } from '@/object-record/record-group/hooks/useRecordGroupVisibility';
 import { recordGroupFieldMetadataComponentState } from '@/object-record/record-group/states/recordGroupFieldMetadataComponentState';
@@ -54,7 +53,7 @@ export const useRecordGroupActions = ({
       throw new Error('recordGroupFieldMetadata is not a non-empty string');
     }
 
-    const settingsPath = `/settings/objects/${objectMetadataItem.namePlural}/${getFieldSlug(recordGroupFieldMetadata)}`;
+    const settingsPath = `/settings/objects/${objectMetadataItem.namePlural}/${recordGroupFieldMetadata.name}`;
 
     navigate(settingsPath);
   }, [

diff --git a/...modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx b/...modules/settings/data-model/object-details/components/SettingsObjectFieldItemTableRow.tsx
@@ -4,7 +4,6 @@ import { useGetRelationMetadata } from '@/object-metadata/hooks/useGetRelationMe
 import { useUpdateOneObjectMetadataItem } from '@/object-metadata/hooks/useUpdateOneObjectMetadataItem';
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
 import { FieldMetadataItem } from '@/object-metadata/types/FieldMetadataItem';
-import { getFieldSlug } from '@/object-metadata/utils/getFieldSlug';
 import { isLabelIdentifierField } from '@/object-metadata/utils/isLabelIdentifierField';
 import { useDeleteRecordFromCache } from '@/object-record/cache/hooks/useDeleteRecordFromCache';
 import { usePrefetchedData } from '@/prefetch/hooks/usePrefetchedData';
@@ -109,7 +108,7 @@ export const SettingsObjectFieldItemTableRow = ({
     !isLabelIdentifier &&
     LABEL_IDENTIFIER_FIELD_METADATA_TYPES.includes(fieldMetadataItem.type);
 
-  const linkToNavigate = `./${getFieldSlug(fieldMetadataItem)}`;
+  const linkToNavigate = `./${fieldMetadataItem.name}`;
 
   const {
     activateMetadataField,

diff --git a/packages/twenty-front/src/pages/settings/data-model/SettingsObjectFieldEdit.tsx b/packages/twenty-front/src/pages/settings/data-model/SettingsObjectFieldEdit.tsx
@@ -18,7 +18,6 @@ import { useFilteredObjectMetadataItems } from '@/object-metadata/hooks/useFilte
 import { useGetRelationMetadata } from '@/object-metadata/hooks/useGetRelationMetadata';
 import { useUpdateOneFieldMetadataItem } from '@/object-metadata/hooks/useUpdateOneFieldMetadataItem';
 import { formatFieldMetadataItemInput } from '@/object-metadata/utils/formatFieldMetadataItemInput';
-import { getFieldSlug } from '@/object-metadata/utils/getFieldSlug';
 import { isLabelIdentifierField } from '@/object-metadata/utils/isLabelIdentifierField';
 import { RecordFieldValueSelectorContextProvider } from '@/object-record/record-store/contexts/RecordFieldValueSelectorContext';
 import { SaveAndCancelButtons } from '@/settings/components/SaveAndCancelButtons/SaveAndCancelButtons';
@@ -58,7 +57,7 @@ export const SettingsObjectFieldEdit = () => {
     useFieldMetadataItem();
 
   const fieldMetadataItem = objectMetadataItem?.fields.find(
-    (fieldMetadataItem) => getFieldSlug(fieldMetadataItem) === fieldSlug,
+    (fieldMetadataItem) => fieldMetadataItem.name === fieldSlug,
   );
 
   const getRelationMetadata = useGetRelationMetadata();