Fix comments

packages/twenty-front/src/modules/favorites/components/WorkspaceFavorites.tsx

@@ -1,4 +1,4 @@
-import { useObjectMetadataItemsInWorkspaceFavorites } from '@/navigation/hooks/useObjectMetadataItemsInWorkspaceFavorites';
+import { useFilteredObjectMetadataItemsForWorkspaceFavorites } from '@/navigation/hooks/useObjectMetadataItemsInWorkspaceFavorites';
 import { NavigationDrawerSectionForObjectMetadataItems } from '@/object-metadata/components/NavigationDrawerSectionForObjectMetadataItems';
 import { NavigationDrawerSectionForObjectMetadataItemsSkeletonLoader } from '@/object-metadata/components/NavigationDrawerSectionForObjectMetadataItemsSkeletonLoader';
 import { useIsPrefetchLoading } from '@/prefetch/hooks/useIsPrefetchLoading';
@@ -10,7 +10,7 @@ export const WorkspaceFavorites = () => {
   const { records: views } = usePrefetchedData<View>(PrefetchKey.AllViews);
 
   const { activeObjectMetadataItems: objectMetadataItemsToDisplay } =
-    useObjectMetadataItemsInWorkspaceFavorites();
+    useFilteredObjectMetadataItemsForWorkspaceFavorites();
 
   const loading = useIsPrefetchLoading();
   if (loading) {

packages/twenty-front/src/modules/navigation/hooks/useObjectMetadataItemsInWorkspaceFavorites.ts

@@ -4,7 +4,7 @@ import { usePrefetchedData } from '@/prefetch/hooks/usePrefetchedData';
 import { PrefetchKey } from '@/prefetch/types/PrefetchKey';
 import { View } from '@/views/types/View';
 
-export const useObjectMetadataItemsInWorkspaceFavorites = () => {
+export const useFilteredObjectMetadataItemsForWorkspaceFavorites = () => {
   const { records: views } = usePrefetchedData<View>(PrefetchKey.AllViews);
 
   const { workspaceFavorites } = useFavorites();

packages/twenty-front/src/modules/object-metadata/components/NavigationDrawerOpenedSection.tsx

@@ -1,9 +1,6 @@
-import { useLocation } from 'react-router-dom';
-import { useRecoilValue } from 'recoil';
-import { isDefined } from 'twenty-ui';
+import { useParams } from 'react-router-dom';
 
-import { currentUserState } from '@/auth/states/currentUserState';
-import { useObjectMetadataItemsInWorkspaceFavorites } from '@/navigation/hooks/useObjectMetadataItemsInWorkspaceFavorites';
+import { useFilteredObjectMetadataItemsForWorkspaceFavorites } from '@/navigation/hooks/useObjectMetadataItemsInWorkspaceFavorites';
 import { NavigationDrawerSectionForObjectMetadataItems } from '@/object-metadata/components/NavigationDrawerSectionForObjectMetadataItems';
 import { NavigationDrawerSectionForObjectMetadataItemsSkeletonLoader } from '@/object-metadata/components/NavigationDrawerSectionForObjectMetadataItemsSkeletonLoader';
 import { useFilteredObjectMetadataItems } from '@/object-metadata/hooks/useFilteredObjectMetadataItems';
@@ -13,8 +10,6 @@ import { PrefetchKey } from '@/prefetch/types/PrefetchKey';
 import { View } from '@/views/types/View';
 
 export const NavigationDrawerOpenedSection = () => {
-  const currentUser = useRecoilValue(currentUserState);
-
   const { activeObjectMetadataItems } = useFilteredObjectMetadataItems();
   const filteredActiveObjectMetadataItems = activeObjectMetadataItems.filter(
     (item) => !item.isRemote,
@@ -23,11 +18,10 @@ export const NavigationDrawerOpenedSection = () => {
   const { records: views } = usePrefetchedData<View>(PrefetchKey.AllViews);
   const loading = useIsPrefetchLoading();
 
-  const currentPath = useLocation().pathname;
-  const currentObjectNamePlural = extractObjectFromCurrentPath(currentPath);
+  const currentObjectNamePlural = useParams().objectNamePlural;
 
-  const { activeObjectMetadataItems: objectMetadataItemsCurrentlyDisplayed } =
-    useObjectMetadataItemsInWorkspaceFavorites();
+  const { activeObjectMetadataItems: workspaceFavoritesObjectMetadataItems } =
+    useFilteredObjectMetadataItemsForWorkspaceFavorites();
 
   if (!currentObjectNamePlural) {
     return;
@@ -42,11 +36,11 @@ export const NavigationDrawerOpenedSection = () => {
   }
 
   const shouldDisplayObjectInOpenedSection =
-    !objectMetadataItemsCurrentlyDisplayed
+    !workspaceFavoritesObjectMetadataItems
       .map((item) => item.id)
       .includes(objectMetadataItem.id);
 
-  if (loading && isDefined(currentUser)) {
+  if (loading) {
     return <NavigationDrawerSectionForObjectMetadataItemsSkeletonLoader />;
   }
 
@@ -61,14 +55,3 @@ export const NavigationDrawerOpenedSection = () => {
     )
   );
 };
-
-const extractObjectFromCurrentPath = (url: string): string | null => {
-  const regex = /^\/objects\/([^/?]+)/;
-  const match = url.match(regex);
-
-  if (isDefined(match) && match.length > 1) {
-    return match[1];
-  }
-
-  return null;
-};

packages/twenty-server/src/database/commands/data-seed-dev-workspace.command.ts

@@ -40,7 +40,7 @@ import { DataSourceService } from 'src/engine/metadata-modules/data-source/data-
 import { FieldMetadataService } from 'src/engine/metadata-modules/field-metadata/field-metadata.service';
 import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
 import { ObjectMetadataService } from 'src/engine/metadata-modules/object-metadata/object-metadata.service';
-import { getExcludedObjectMetadataIdsFromFavoritesPrefill } from 'src/engine/utils/get-excluded-object-metadata-ids-from-favorites-prefill';
+import { shouldSeedWorkspaceFavorite } from 'src/engine/utils/should-seed-workspace-favorite';
 import { WorkspaceDataSourceService } from 'src/engine/workspace-datasource/workspace-datasource.service';
 import { viewPrefillData } from 'src/engine/workspace-manager/standard-objects-prefill-data/view';
 import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
@@ -218,18 +218,14 @@ export class DataSeedWorkspaceCommand extends CommandRunner {
               isWorkflowEnabled,
             );
 
-            const excludedObjectMetadataIdsFromFavoritesPrefill =
-              getExcludedObjectMetadataIdsFromFavoritesPrefill(
-                objectMetadataMap,
-              );
-
             await seedWorkspaceFavorites(
               viewDefinitionsWithId
                 .filter(
                   (view) =>
                     view.key === 'INDEX' &&
-                    !excludedObjectMetadataIdsFromFavoritesPrefill.includes(
+                    shouldSeedWorkspaceFavorite(
                       view.objectMetadataId,
+                      objectMetadataMap,
                     ),
                 )
                 .map((view) => view.id),

packages/twenty-server/src/engine/utils/should-seed-workspace-favorite.ts

@@ -0,0 +1,10 @@
+import { STANDARD_OBJECT_IDS } from 'src/engine/workspace-manager/workspace-sync-metadata/constants/standard-object-ids';
+
+export const shouldSeedWorkspaceFavorite = (
+  objectMetadataId,
+  objectMetadataMap,
+) => [
+  objectMetadataId !==
+    objectMetadataMap[STANDARD_OBJECT_IDS.workflowVersion].id &&
+    objectMetadataId !== objectMetadataMap[STANDARD_OBJECT_IDS.workflowRun].id,
+];

packages/twenty-server/src/engine/workspace-manager/demo-objects-prefill-data/demo-objects-prefill-data.ts

@@ -2,7 +2,7 @@ import { DataSource, EntityManager } from 'typeorm';
 
 import { seedWorkspaceFavorites } from 'src/database/typeorm-seeds/workspace/favorites';
 import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { getExcludedObjectMetadataIdsFromFavoritesPrefill } from 'src/engine/utils/get-excluded-object-metadata-ids-from-favorites-prefill';
+import { shouldSeedWorkspaceFavorite } from 'src/engine/utils/should-seed-workspace-favorite';
 import { companyPrefillDemoData } from 'src/engine/workspace-manager/demo-objects-prefill-data/company';
 import { opportunityPrefillDemoData } from 'src/engine/workspace-manager/demo-objects-prefill-data/opportunity';
 import { personPrefillDemoData } from 'src/engine/workspace-manager/demo-objects-prefill-data/person';
@@ -41,11 +41,9 @@ export const demoObjectsPrefillData = async (
         isWorkflowEnabled,
       );
 
-      const excludedObjectMetadataIdsFromFavoritesPrefill = getExcludedObjectMetadataIdsFromFavoritesPrefill(objectMetadataMap);
-
       await seedWorkspaceFavorites(
         viewDefinitionsWithId
-          .filter((view) => view.key === 'INDEX' && !excludedObjectMetadataIdsFromFavoritesPrefill.includes(view.objectMetadataId))
+          .filter((view) => view.key === 'INDEX' && shouldSeedWorkspaceFavorite(view.objectMetadataId, objectMetadataMap))
           .map((view) => view.id),
         entityManager,
         schemaName,

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/standard-objects-prefill-data.ts

@@ -2,7 +2,7 @@ import { DataSource, EntityManager } from 'typeorm';
 
 import { seedWorkspaceFavorites } from 'src/database/typeorm-seeds/workspace/favorites';
 import { ObjectMetadataEntity } from 'src/engine/metadata-modules/object-metadata/object-metadata.entity';
-import { getExcludedObjectMetadataIdsFromFavoritesPrefill } from 'src/engine/utils/get-excluded-object-metadata-ids-from-favorites-prefill';
+import { shouldSeedWorkspaceFavorite } from 'src/engine/utils/should-seed-workspace-favorite';
 import { companyPrefillData } from 'src/engine/workspace-manager/standard-objects-prefill-data/company';
 import { personPrefillData } from 'src/engine/workspace-manager/standard-objects-prefill-data/person';
 import { viewPrefillData } from 'src/engine/workspace-manager/standard-objects-prefill-data/view';
@@ -44,16 +44,14 @@ export const standardObjectsPrefillData = async (
       isWorkflowEnabled,
     );
 
-    const excludedObjectMetadataIdsFromFavoritesPrefill =
-      getExcludedObjectMetadataIdsFromFavoritesPrefill(objectMetadataMap);
-
     await seedWorkspaceFavorites(
       viewDefinitionsWithId
         .filter(
           (view) =>
             view.key === 'INDEX' &&
-            !excludedObjectMetadataIdsFromFavoritesPrefill.includes(
+            shouldSeedWorkspaceFavorite(
               view.objectMetadataId,
+              objectMetadataMap,
             ),
         )
         .map((view) => view.id),

packages/twenty-server/src/engine/workspace-manager/standard-objects-prefill-data/view.ts

@@ -10,7 +10,7 @@ import { peopleAllView } from 'src/engine/workspace-manager/standard-objects-pre
 import { tasksAllView } from 'src/engine/workspace-manager/standard-objects-prefill-data/views/tasks-all.view';
 import { tasksByStatusView } from 'src/engine/workspace-manager/standard-objects-prefill-data/views/tasks-by-status.view';
 import { workflowRunsAllView } from 'src/engine/workspace-manager/standard-objects-prefill-data/views/workflow-runs-all.view';
-import { workflowVersionsAllView } from 'src/engine/workspace-manager/standard-objects-prefill-data/views/workflow-versions.view';
+import { workflowVersionsAllView } from 'src/engine/workspace-manager/standard-objects-prefill-data/views/workflow-versions-all.view';
 import { workflowsAllView } from 'src/engine/workspace-manager/standard-objects-prefill-data/views/workflows-all.view';
 
 export const viewPrefillData = async (