feat: remove validation for raw json field

twentyhq · Dec 18, 2024 · 8bed07f · 8bed07f
1 parent c91f188
commit 8bed07f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 29 deletions.
diff --git a/...nt/src/modules/object-record/record-field/form-types/components/FormRawJsonFieldInput.tsx b/...nt/src/modules/object-record/record-field/form-types/components/FormRawJsonFieldInput.tsx
@@ -5,7 +5,6 @@ import { TextVariableEditor } from '@/object-record/record-field/form-types/comp
 import { useTextVariableEditor } from '@/object-record/record-field/form-types/hooks/useTextVariableEditor';
 import { VariablePickerComponent } from '@/object-record/record-field/form-types/types/VariablePickerComponent';
 import { InputLabel } from '@/ui/input/components/InputLabel';
-import { CAPTURE_VARIABLE_TAG_REGEX } from '@/workflow/search-variables/utils/initializeEditorContent';
 import { useId } from 'react';
 import { isDefined } from 'twenty-ui';
 import { turnIntoEmptyStringIfWhitespacesOnly } from '~/utils/string/turnIntoEmptyStringIfWhitespacesOnly';
@@ -43,24 +42,6 @@ export const FormRawJsonFieldInput = ({
         return;
       }
 
-      const textWithReplacedVariables = text.replaceAll(
-        new RegExp(CAPTURE_VARIABLE_TAG_REGEX, 'g'),
-        '0',
-      );
-
-      let isValidJson;
-      try {
-        JSON.parse(textWithReplacedVariables);
-
-        isValidJson = true;
-      } catch {
-        isValidJson = false;
-      }
-
-      if (!isValidJson) {
-        return;
-      }
-
       onPersist(text);
     },
   });

diff --git a/...t-record/record-field/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx b/...t-record/record-field/form-types/components/__stories__/FormRawJsonFieldInput.stories.tsx
@@ -58,17 +58,15 @@ export const SaveValidJson: Story = {
     const editor = canvasElement.querySelector('.ProseMirror > p');
     expect(editor).toBeVisible();
 
-    await Promise.all([
-      userEvent.type(editor, '{{ "a": {{ "b" :  "d" } }'),
+    await userEvent.type(editor, '{{ "a": {{ "b" :  "d" } }');
 
-      waitFor(() => {
-        expect(args.onPersist).toHaveBeenCalledWith('{ "a": { "b" :  "d" } }');
-      }),
-    ]);
+    await waitFor(() => {
+      expect(args.onPersist).toHaveBeenCalledWith('{ "a": { "b" :  "d" } }');
+    });
   },
 };
 
-export const IgnoreInvalidJson: Story = {
+export const DoesNotIgnoreInvalidJson: Story = {
   args: {
     placeholder: 'Enter valid json',
     onPersist: fn(),
@@ -81,7 +79,7 @@ export const IgnoreInvalidJson: Story = {
 
     await userEvent.click(canvasElement);
 
-    expect(args.onPersist).not.toHaveBeenCalled();
+    expect(args.onPersist).toHaveBeenCalledWith('lol');
   },
 };
 
@@ -211,7 +209,7 @@ export const ClearField: Story = {
  * Line breaks are not authorized in JSON strings. Users should instead put newlines characters themselves.
  * See https://stackoverflow.com/a/42073.
  */
-export const BreaksWhenUserInsertsNewlineInJsonString: Story = {
+export const DoesNotBreakWhenUserInsertsNewlineInJsonString: Story = {
   args: {
     placeholder: 'Enter valid json',
     onPersist: fn(),
@@ -224,7 +222,7 @@ export const BreaksWhenUserInsertsNewlineInJsonString: Story = {
 
     await userEvent.click(canvasElement);
 
-    expect(args.onPersist).not.toHaveBeenCalled();
+    expect(args.onPersist).toHaveBeenCalled();
   },
 };