Skip to content

Commit

Permalink
minor fix -- missing margin bottom for orphan favorites (#9111)
Browse files Browse the repository at this point in the history
this PR is a followup of the favorites followups which was the follow-up
of some other PR :)
  • Loading branch information
ehconitin authored Dec 18, 2024
1 parent e0f1db2 commit 8623585
Showing 1 changed file with 24 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ const StyledEmptyContainer = styled.div`
width: 100%;
`;

const StyledOrphanFavoritesContainer = styled.div`
margin-bottom: ${({ theme }) => theme.betweenSiblingsGap};
`;

export const CurrentWorkspaceMemberOrphanFavorites = () => {
const { sortedFavorites: favorites } = useFavorites();
const { deleteFavorite } = useDeleteFavorite();
Expand All @@ -38,24 +42,26 @@ export const CurrentWorkspaceMemberOrphanFavorites = () => {
index={index}
isInsideScrollableContainer={true}
itemComponent={
<NavigationDrawerItem
label={favorite.labelIdentifier}
Icon={() => <FavoriteIcon favorite={favorite} />}
active={isLocationMatchingFavorite(
currentPath,
currentViewPath,
favorite,
)}
to={favorite.link}
rightOptions={
<LightIconButton
Icon={IconHeartOff}
onClick={() => deleteFavorite(favorite.id)}
accent="tertiary"
/>
}
isDragging={isDragging}
/>
<StyledOrphanFavoritesContainer>
<NavigationDrawerItem
label={favorite.labelIdentifier}
Icon={() => <FavoriteIcon favorite={favorite} />}
active={isLocationMatchingFavorite(
currentPath,
currentViewPath,
favorite,
)}
to={favorite.link}
rightOptions={
<LightIconButton
Icon={IconHeartOff}
onClick={() => deleteFavorite(favorite.id)}
accent="tertiary"
/>
}
isDragging={isDragging}
/>
</StyledOrphanFavoritesContainer>
}
/>
))
Expand Down

0 comments on commit 8623585

Please sign in to comment.