more refatoring and code cleaning

packages/twenty-front/src/modules/object-record/record-board/record-board-column/components/RecordBoardColumnDropdownMenu.tsx

@@ -2,7 +2,9 @@ import styled from '@emotion/styled';
 import { useCallback, useContext, useRef } from 'react';
 
 import { CoreObjectNameSingular } from '@/object-metadata/types/CoreObjectNameSingular';
+import { RecordBoardContext } from '@/object-record/record-board/contexts/RecordBoardContext';
 import { RecordBoardColumnContext } from '@/object-record/record-board/record-board-column/contexts/RecordBoardColumnContext';
+import { useAddNewCard } from '@/object-record/record-board/record-board-column/hooks/useAddNewCard';
 import { useAddNewOpportunity } from '@/object-record/record-board/record-board-column/hooks/useAddNewOpportunity';
 import { SingleEntitySelect } from '@/object-record/relation-picker/components/SingleEntitySelect';
 import { DropdownMenu } from '@/ui/layout/dropdown/components/DropdownMenu';
@@ -28,7 +30,7 @@ export const RecordBoardColumnDropdownMenu = ({
   onClose,
 }: RecordBoardColumnDropdownMenuProps) => {
   const boardColumnMenuRef = useRef<HTMLDivElement>(null);
-
+  const { objectMetadataItem } = useContext(RecordBoardContext);
   const closeMenu = useCallback(() => {
     onClose();
   }, [onClose]);
@@ -40,8 +42,23 @@ export const RecordBoardColumnDropdownMenu = ({
 
   const { columnDefinition } = useContext(RecordBoardColumnContext);
 
-  const { isCreatingCard, handleNewClick, handleCancel, handleEntitySelect } =
-    useAddNewOpportunity();
+  const {
+    isCreatingCard,
+    handleAddNewOpportunityClick,
+    handleCancel,
+    handleEntitySelect,
+  } = useAddNewOpportunity();
+  const { handleAddNewCardClick } = useAddNewCard();
+
+  const isOpportunity =
+    objectMetadataItem.nameSingular === CoreObjectNameSingular.Opportunity;
+
+  const handleClick = isOpportunity
+    ? handleAddNewOpportunityClick
+    : () => {
+        handleAddNewCardClick();
+        closeMenu();
+      };
 
   return (
     <StyledMenuContainer ref={boardColumnMenuRef}>
@@ -72,7 +89,7 @@ export const RecordBoardColumnDropdownMenu = ({
               />
             ))}
             <MenuItem
-              onClick={handleNewClick}
+              onClick={handleClick}
               LeftIcon={IconPlus}
               text="Add Record"
             />

packages/twenty-front/src/modules/object-record/record-board/record-board-column/components/RecordBoardColumnNewButton.tsx

@@ -1,10 +1,8 @@
 import { useTheme } from '@emotion/react';
 import styled from '@emotion/styled';
-import { useContext } from 'react';
 import { IconPlus } from 'twenty-ui';
 
-import { RecordBoardContext } from '@/object-record/record-board/contexts/RecordBoardContext';
-import { RecordBoardColumnContext } from '@/object-record/record-board/record-board-column/contexts/RecordBoardColumnContext';
+import { useAddNewCard } from '@/object-record/record-board/record-board-column/hooks/useAddNewCard';
 
 const StyledButton = styled.button`
   align-items: center;
@@ -25,21 +23,11 @@ const StyledButton = styled.button`
 
 export const RecordBoardColumnNewButton = () => {
   const theme = useTheme();
-  const { columnDefinition } = useContext(RecordBoardColumnContext);
-  const { createOneRecord, selectFieldMetadataItem } =
-    useContext(RecordBoardContext);
-
-  const onNewClick = () => {
-    createOneRecord({
-      [selectFieldMetadataItem.name]: columnDefinition.value,
-      position: 'last',
-    });
-  };
-
+  const { handleAddNewCardClick } = useAddNewCard();
   return (
-    <StyledButton onClick={onNewClick}>
+    <StyledButton onClick={handleAddNewCardClick}>
       <IconPlus size={theme.icon.size.md} />
-      New agaga
+      New
     </StyledButton>
   );
 };

packages/twenty-front/src/modules/object-record/record-board/record-board-column/components/RecordBoardColumnNewOpportunityButton.tsx

@@ -25,8 +25,12 @@ const StyledButton = styled.button`
 
 export const RecordBoardColumnNewOpportunityButton = () => {
   const theme = useTheme();
-  const { isCreatingCard, handleNewClick, handleCancel, handleEntitySelect } =
-    useAddNewOpportunity();
+  const {
+    isCreatingCard,
+    handleAddNewOpportunityClick,
+    handleCancel,
+    handleEntitySelect,
+  } = useAddNewOpportunity();
   return (
     <>
       {isCreatingCard ? (
@@ -39,7 +43,7 @@ export const RecordBoardColumnNewOpportunityButton = () => {
           selectedRelationRecordIds={[]}
         />
       ) : (
-        <StyledButton onClick={handleNewClick}>
+        <StyledButton onClick={handleAddNewOpportunityClick}>
           <IconPlus size={theme.icon.size.md} />
           New
         </StyledButton>

packages/twenty-front/src/modules/object-record/record-board/record-board-column/hooks/useAddNewCard.ts

@@ -0,0 +1,20 @@
+import { RecordBoardContext } from '@/object-record/record-board/contexts/RecordBoardContext';
+import { RecordBoardColumnContext } from '@/object-record/record-board/record-board-column/contexts/RecordBoardColumnContext';
+import { useContext } from 'react';
+
+export const useAddNewCard = () => {
+  const { columnDefinition } = useContext(RecordBoardColumnContext);
+  const { createOneRecord, selectFieldMetadataItem } =
+    useContext(RecordBoardContext);
+
+  const handleAddNewCardClick = () => {
+    createOneRecord({
+      [selectFieldMetadataItem.name]: columnDefinition.value,
+      position: 'last',
+    });
+  };
+
+  return {
+    handleAddNewCardClick,
+  };
+};

packages/twenty-front/src/modules/object-record/record-board/record-board-column/hooks/useAddNewOpportunity.ts

@@ -45,7 +45,7 @@ export const useAddNewOpportunity = () => {
     ],
   );
 
-  const handleNewClick = useCallback(() => {
+  const handleAddNewOpportunityClick = useCallback(() => {
     setIsCreatingCard(true);
     setHotkeyScopeAndMemorizePreviousScope(
       RelationPickerHotkeyScope.RelationPicker,
@@ -61,7 +61,7 @@ export const useAddNewOpportunity = () => {
   return {
     isCreatingCard,
     handleEntitySelect,
-    handleNewClick,
+    handleAddNewOpportunityClick,
     handleCancel,
   };
 };