Fix onboarding status refacto (#6533)

see comments in #6531 (review) - rename method - add check before setting create profile pending user var
twentyhq · Aug 7, 2024 · 10817c5 · 10817c5
1 parent 8408cf6
commit 10817c5
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 13 deletions.
diff --git a/...rver/src/database/commands/upgrade-version/0-23/0-23-backfill-new-onboarding-user-vars.ts b/...rver/src/database/commands/upgrade-version/0-23/0-23-backfill-new-onboarding-user-vars.ts
@@ -73,7 +73,7 @@ export class BackfillNewOnboardingUserVarsCommand extends CommandRunner {
       });
 
       for (const user of workspace.users) {
-        await this.onboardingService.setOnboardingCreateProfileCompletion({
+        await this.onboardingService.setOnboardingCreateProfilePending({
           userId: user.id,
           workspaceId: workspace.id,
           value: true,

diff --git a/packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts b/packages/twenty-server/src/engine/core-modules/auth/services/sign-in-up.service.ts
@@ -197,11 +197,13 @@ export class SignInUpService {
       value: true,
     });
 
-    await this.onboardingService.setOnboardingCreateProfileCompletion({
-      userId: user.id,
-      workspaceId: workspace.id,
-      value: true,
-    });
+    if (firstName === '' && lastName === '') {
+      await this.onboardingService.setOnboardingCreateProfilePending({
+        userId: user.id,
+        workspaceId: workspace.id,
+        value: true,
+      });
+    }
 
     return user;
   }
@@ -257,11 +259,13 @@ export class SignInUpService {
       value: true,
     });
 
-    await this.onboardingService.setOnboardingCreateProfileCompletion({
-      userId: user.id,
-      workspaceId: workspace.id,
-      value: true,
-    });
+    if (firstName === '' && lastName === '') {
+      await this.onboardingService.setOnboardingCreateProfilePending({
+        userId: user.id,
+        workspaceId: workspace.id,
+        value: true,
+      });
+    }
 
     await this.onboardingService.setOnboardingInviteTeamPending({
       workspaceId: workspace.id,

diff --git a/packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.ts b/packages/twenty-server/src/engine/core-modules/onboarding/onboarding.service.ts
@@ -131,7 +131,7 @@ export class OnboardingService {
     });
   }
 
-  async setOnboardingCreateProfileCompletion({
+  async setOnboardingCreateProfilePending({
     userId,
     workspaceId,
     value,

diff --git a/...es/twenty-server/src/engine/core-modules/workspace/workspace-workspace-member.listener.ts b/...es/twenty-server/src/engine/core-modules/workspace/workspace-workspace-member.listener.ts
@@ -36,7 +36,7 @@ export class WorkspaceWorkspaceMemberListener {
       return;
     }
 
-    await this.onboardingService.setOnboardingCreateProfileCompletion({
+    await this.onboardingService.setOnboardingCreateProfilePending({
       userId: payload.userId,
       workspaceId: payload.workspaceId,
       value: false,
-Original file line number
+Diff line change
@@ Expand Up / @@ -131,7 +131,7 @@ export class OnboardingService { @@
         });
       }
-      async setOnboardingCreateProfileCompletion({
+      async setOnboardingCreateProfilePending({
         userId,
         workspaceId,
         value,
@@ Expand Down @@