Map iterator #69
Merged
Map iterator #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haobo Gu <[email protected]>
|
Current implementation is a very initial implementation. It requires a data buffer for creating |
Signed-off-by: Haobo Gu <[email protected]>
|
@diondokter Hi! I think I've finished it. According my tests, compared with just loading all items, the iterator can get 300x speedup(6482ms -> 22ms). Do you have any comments on this PR? |
HaoboGu
force-pushed
the
feat/map_iterator
branch
2 times, most recently
from
e759543 to
c297631
Compare
Signed-off-by: Haobo Gu <[email protected]>
HaoboGu
force-pushed
the
feat/map_iterator
branch
from
c297631 to
0b0dc63
Compare
diondokter
requested changes
Dec 11, 2024
|
300x speedup is pretty dope :D |
Signed-off-by: Haobo Gu <[email protected]>
diondokter
reviewed
Dec 13, 2024
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
Signed-off-by: Haobo Gu <[email protected]>
diondokter
approved these changes
Dec 19, 2024
|
Ah there's some updating I need to do which is why the CI fails. I'll merge regardless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide an iterator on map values, related to #65 and #65 (comment)