Add back alt js mime for backwards compatibility #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while reviewing the latest changes that in b55342e all instances of
application/javascriptwere changed to betext/javascript, buttext/javascriptwas already there in several places in addition toapplication/javascriptso now it's duplicated.Example:
memory-serve/memory-serve/src/asset.rs
Lines 19 to 20 in b55342e
I think the after noticing that it was already including both in some places you would want to instead simply add
text/javascriptto the one place it was missing. That's the most backwards compatible and what I did in this PR. It wouldn't bother me if you wanted to just remove the duplicates instead, I just made the PR to save you some time so I did what I thought you'd want.