Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using calc() for columns width #27374

Closed
wants to merge 6 commits into from
Closed

Using calc() for columns width #27374

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e26e22
updated make-col and make-col-offset mixins to let browsers calculate…
IvanKalinin Oct 8, 2018
4229f12
Merge branch 'v4-dev' into fix--column-width-calculation
XhmikosR Oct 16, 2018
0cf9507
Merge branch 'v4-dev' into fix--column-width-calculation
IvanKalinin Oct 18, 2018
9ac0ba4
Merge branch 'v4-dev' into fix--column-width-calculation
XhmikosR Nov 4, 2018
2238d16
Merge branch 'v4-dev' into fix--column-width-calculation
XhmikosR Dec 3, 2018
4613a5e
Merge branch 'v4-dev' into fix--column-width-calculation
XhmikosR Dec 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scss/mixins/_grid.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@
}

@mixin make-col($size, $columns: $grid-columns) {
flex: 0 0 percentage($size / $columns);
flex: 0 0 calc(100% / #{$columns} * #{$size});
// Add a `max-width` to ensure content within each column does not blow out
// the width of the column. Applies to IE10+ and Firefox. Chrome and Safari
// do not appear to require this.
max-width: percentage($size / $columns);
max-width: calc(100% / #{$columns} * #{$size});
}

@mixin make-col-offset($size, $columns: $grid-columns) {
$num: $size / $columns;
margin-left: if($num == 0, 0, percentage($num));
margin-left: if($num == 0, 0, calc(100% / #{$columns} * #{$size}));
}