Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric Specific Fixes #666

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Fabric Specific Fixes #666

merged 6 commits into from
Nov 14, 2024

Conversation

bradmontierth
Copy link
Contributor

@bradmontierth bradmontierth commented Nov 14, 2024

Describe your changes

Please include a summary of any changes.

  • concat null + something = null on fabric. This made our provider npi logic which concat first "," last non null so a blank name was pulled into the coalesce instead of the organization name
  • Fabric ranks null first ahead of integers causing issue with service category prioritization. Explicitly coalesce the null with 99999 to fix the behavior
  • count(1) returns an integer which wasn't able to convert to numeric for PMPM and per calculations
  • divide by zero fix
  • creating separate tag for data_quality_mart_review tables which rely on core vs data_quality which rely on input layer

How has this been tested?

Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.
Ran in client enviro on fabric
Ci testing

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

@sarah-tuva sarah-tuva merged commit 3cfb261 into main Nov 14, 2024
8 checks passed
@sarah-tuva sarah-tuva deleted the working_mc_brad branch November 14, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants