Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix limit logic in financial_pmpm__stg_provider_attribution #637

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

sarah-tuva
Copy link
Member

@sarah-tuva sarah-tuva commented Oct 29, 2024

Describe your changes

Please include a summary of any changes.

Added "limit" logic for Fabric adapter to financial_pmpm__stg_provider_attribution.

How has this been tested?

Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.

Tested various combinations of vars.

"clinical_enabled":true,"claims_enabled":true
"claims_enabled":true,"provider_attribution_enabled":true
"claims_enabled":true
"clinical_enabled":true
"provider_attribution_enabled":true

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

@sarah-tuva sarah-tuva added the bug Something isn't working label Oct 29, 2024
@thutuva thutuva merged commit fe14475 into main Oct 29, 2024
8 checks passed
@thutuva thutuva deleted the bug-fix-pmpm-attribution branch October 29, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants