Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Quality Measure: Statin Use in Persons with Diabetes #633

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

utsavpaudel
Copy link
Contributor

Describe your changes

Implemented Quality Measure SUPD: Statin Use in Persons with Diabetes according to the specification document.

How has this been tested?

Ran dbt build against Snowflake and BigQuery. A validation document has also been prepared to corroborate the output.

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

@sarah-tuva sarah-tuva self-requested a review October 24, 2024 17:23

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

@sarah-tuva
Copy link
Member

Hi @utsavpaudel! Thanks for submitting this PR. It looks great to me! Just wanted to let you know that I'm looking into an issue with one of the CI tests failing. I don't believe it's related to any changes you made. I'll merge this once I figure out what's going on.

@thutuva
Copy link
Member

thutuva commented Oct 25, 2024

Hi @utsavpaudel - The reason why your PR is failing is because limit 0 is not supported by fabric so I've created a macro to fix this. In the model financial_pmpm__stg_provider_attribution the limit 0 needs to be replaced with {{ limit_zero()}}.

I'm sorry that this bug got through and if effecting your PR. I'll be looking into it to try and prevent this from happening again. Thanks!

CC @sarah-tuva

Copy link

Workflow has finished with the following statuses:

  • BigQuery Clinical and Claims: success
  • BigQuery Claims: success
  • BigQuery Clinical: success
  • Fabric Clinical and Claims: success
  • Fabric Claims: success
  • Fabric Clinical: success
  • Redshift Clinical and Claims: success
  • Redshift Claims: success
  • Redshift Clinical: success
  • Snowflake Clinical and Claims: success
  • Snowflake Claims: success
  • Snowflake Clinical: success

@sarah-tuva sarah-tuva merged commit 3e16eda into tuva-health:main Oct 29, 2024
4 of 8 checks passed
@utsavpaudel utsavpaudel deleted the supd branch October 30, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants