Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dqi mart join fix #630

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Dqi mart join fix #630

merged 7 commits into from
Oct 24, 2024

Conversation

bradmontierth
Copy link
Contributor

@bradmontierth bradmontierth commented Oct 22, 2024

Describe your changes

Fixing the joins between tables in data quality where composite key was constructed inconsistently
Fixing data type of encounter_id to be consistant in core.encounter and core.medical_claim
Adding views for PBI analytics dashboards.

How has this been tested?

Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.
Review DQ and PMPM dashboards
CI testing

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • (New models) I have added the variable tuva_last_run to the final output
  • (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • I have updated dbt docs
  • I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Loom link

@thutuva thutuva merged commit ca51597 into main Oct 24, 2024
10 checks passed
@thutuva thutuva deleted the dqi_mart_join_fix branch October 24, 2024 13:11
@thutuva thutuva added the bug Something isn't working label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants