bugfix: RANDOM ROWID should be respected in VACUUM and bulk insert ops
#1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The register `regNextRowid` contains the `LIBSQL_RANDOM_ROWID_MARKER` value which tells the VDBE to use a random value for row ids. The method `xferOptimization` is used in `VACUUM` and bulk insert routines where data from one table is inserted in another. Since the data is inserted in a loop, it checks for max rowid once and then keeps inserting it serially. Hence we pass the marker in each call, so that random id is generated.
MarinPostma
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bugfix: pass
regNextRowidtoOP_NewRowidcall inxferOptimizationThe register
regNextRowidcontains theLIBSQL_RANDOM_ROWID_MARKERvaluewhich tells the VDBE to use a random value for row ids. The method
xferOptimizationis used in
VACUUMand bulk insert routines where data from one table isinserted in another. Since the data is inserted in a loop, it checks for
max rowid once and then keeps inserting it serially. Hence we pass the marker
in each call, so that random id is generated.
Tests added for:
RANDOM ROWIDtable option #929RANDOM ROWID#1046In both cases, the table should end up random rowids, but they seem to have sequential ones.