review edits

tursodatabase · Feb 26, 2024 · 96da442 · 96da442
1 parent 571072a
commit 96da442
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/libsql-server/src/auth/authenticated.rs b/libsql-server/src/auth/authenticated.rs
@@ -62,8 +62,8 @@ impl Authenticated {
             )),
             Authenticated::Authorized(a) => {
                 if !a.has_right(Scope::Namespace(namespace.clone()), perm) {
-                    return Err(crate::Error::NotAuthorized(format!(
-                                "Current session doest not have {perm:?} permission to namespace {namespace}")));
+                    Err(crate::Error::NotAuthorized(format!(
+                                "Current session doest not have {perm:?} permission to namespace {namespace}")))
                 } else {
                     Ok(())
                 }

diff --git a/libsql-server/src/auth/authorized.rs b/libsql-server/src/auth/authorized.rs
@@ -33,8 +33,8 @@ impl Authorized {
     pub fn merge_legacy(&mut self, namespace: NamespaceName, perm: Permission) {
         let scope = match perm {
             Permission::Read => self.read_only.get_or_insert_with(Default::default),
-            Permission::Write => self.read_only.get_or_insert_with(Default::default),
-            Permission::AttachRead => todo!("unsupported"),
+            Permission::Write => self.read_write.get_or_insert_with(Default::default),
+            Permission::AttachRead => self.read_only_attach.get_or_insert_with(Default::default),
         };
 
         scope