use simpler batch input #255
Merged
+77
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@notrab I think we need to change |
|
@penberg you're right, I was thinking this was |
penberg
reviewed
Aug 28, 2024
| @@ -255,7 +256,7 @@ export async function executeHranaBatch( | |||
| disableForeignKeys: boolean = false, | |||
| ): Promise<Array<ResultSet>> { | |||
| if (disableForeignKeys) { | |||
| batch.step().run("PRAGMA foreign_keys=off") | |||
| batch.step().run("PRAGMA foreign_keys=off"); | |||
There was a problem hiding this comment.
Prettier ran on commit, have the rules changed?
| @@ -287,7 +288,7 @@ export async function executeHranaBatch( | |||
| .condition(hrana.BatchCond.not(hrana.BatchCond.ok(commitStep))); | |||
| rollbackStep.run("ROLLBACK").catch((_) => undefined); | |||
| if (disableForeignKeys) { | |||
| batch.step().run("PRAGMA foreign_keys=on") | |||
| batch.step().run("PRAGMA foreign_keys=on"); | |||
There was a problem hiding this comment.
Prettier ran on commit, have the rules changed?
packages/libsql-client/src/hrana.ts
Outdated
| @@ -31,7 +32,7 @@ export abstract class HranaTransaction implements Transaction { | |||
| abstract close(): void; | |||
| abstract get closed(): boolean; | |||
|
|
|||
| execute(stmt: InStatement): Promise<ResultSet> { | |||
| async execute(stmt: InStatement): Promise<ResultSet> { | |||
| async migrate( | ||
| stmts: Array<InStatement>, | ||
| ): Promise<Array<ResultSet>> { | ||
| async migrate(stmts: Array<InStatement>): Promise<Array<ResultSet>> { |
There was a problem hiding this comment.
Prettier ran on commit, have the rules changed?
|
guys is there a reason this isnt merged yet? |
giovannibenussi
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251
@penberg I didn't yet touch
sqlite3.tsbecause updating that might break the compatibility... I'm not sure, wdyt?Hopefully we can refactor these classes at some point so we don't have to duplicate so much 😅