Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev handle gloss and pulse backend #11

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Dev handle gloss and pulse backend #11

wants to merge 16 commits into from

Conversation

turion
Copy link
Owner

@turion turion commented Aug 8, 2020

  • Changelog entry

@turion
Copy link
Owner Author

turion commented Aug 8, 2020

Merge #2 first

This was referenced Aug 8, 2020
Merged
Open
@turion
Copy link
Owner Author

turion commented Aug 8, 2020

  • Symlink to single .ghci template

@turion turion force-pushed the dev_handle_gloss_and_pulse_backend branch 2 times, most recently from 1321d55 to 1daf52f Compare August 8, 2020 09:50
@turion
Copy link
Owner Author

turion commented Aug 8, 2020

  • Strict in quickcheck as well

@turion turion force-pushed the dev_handle_gloss_and_pulse_backend branch 3 times, most recently from 87be9e9 to c19d124 Compare August 8, 2020 13:38
@turion
Copy link
Owner Author

turion commented Aug 8, 2020

  • Document handle stuff with a good example or reference to test file and backends

@turion turion force-pushed the dev_handle_gloss_and_pulse_backend branch from c19d124 to 4c594a1 Compare August 8, 2020 20:36
@turion
Copy link
Owner Author

turion commented Aug 8, 2020

  • Test & add RecordWildCards to all .ghcis or even globally

@turion turion force-pushed the dev_handle_gloss_and_pulse_backend branch 9 times, most recently from 0b94e94 to bf4018d Compare August 14, 2020 10:02
@turion turion mentioned this pull request Aug 14, 2020
Closed
@turion turion force-pushed the dev_handle_gloss_and_pulse_backend branch from bf4018d to e042ff8 Compare August 21, 2020 13:30
turion
turion commented Nov 25, 2020
View reviewed changes
gears/app/Gears.hs
phaseMaybe <- glossWrapC defaultSettings glossCell -< ()
phase <- keep 0 -< phaseMaybe
pulseWrapC 1500 pulseCell -< phase
-- printTime "mainCell pulse: " -< ()
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superfluous comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@turion