This repository has been archived by the owner on Jul 28, 2018. It is now read-only.
fix rails 5 deprecations #671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this backward-compatible with Rails 4? |
Not fully, I think. |
|
Ping @rafaelfranca, would you be open to a PR that removes compatibility for Ruby <2, maybe even Rails <4.2? We cannot yet switch to TL 5 in our project, so we want to keep using TL-classic for the time being. |
|
what's the status here? |
|
I'd prefer to not remove support to Rails 4.2 right now. So can we conditionally check the Rails version where it is necessary? |
|
I can take a look how far I can get, but first #678 would need to get merged. |
|
hrm, I guess that whole testing stuff should go to 2-5-stable, like this PR? |
|
please see #679 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #665
@dhh mentioned (rails/rails#24018 (comment)) that the maintainers would be open to releasing a new version of turbolinks-classic that fixes these deprecations, so I humbly submit this PR for review. 😁