Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packages/tuono): config – add optimizeDeps and plugins to vite options #197

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

marcalexiei
Copy link
Member

@marcalexiei marcalexiei commented Dec 5, 2024

Context & Description

Close #183.

Remove mdx related config from tuono npm package


@marcalexiei marcalexiei marked this pull request as ready for review December 8, 2024 08:44
* From a given {@link TuonoConfig} return a `vite` "mergeable" {@link InlineConfig}
* including all default tuono related options
*/
function createBaseViteConfigFromTuonoConfig(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks amazing. I left a very little comment about a console.log.

Copy link
Member

@Valerioageno Valerioageno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@Valerioageno Valerioageno merged commit c6e93c2 into main Dec 8, 2024
7 checks passed
@Valerioageno Valerioageno deleted the feat/remove-mdx branch December 8, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Refactor]: Remove mdx references from tuono npm package
2 participants