Do not attempt to retrieve magic cookie from MP3 files. #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 15, 2016 13:40
MP3 files do not have magic cookies https://www.google.ch/patents/US20090019087 so an attempt to retrieve magic cookie from mp3 file causes method to return before the converter was created.
|
Added handling of Error description:
|
… find out if the track if fully recorded.
|
Hi @belakva and thanks for the PR. Could you please sort the merge conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #298
MP3 files do not have magic cookies so an attempt to retrieve magic cookie from mp3 file causes method to return before the converter was created.
@tumtumtum please, review this change. It might be, that original intent was to check for
(self->currentlyReadingEntry.dataSource.audioFileTypeHint == kAudioFileAAC_ADTSType)instead.