Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta data support #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Meta data support #131

wants to merge 1 commit into from

Conversation

tgrbin
Copy link

@tgrbin tgrbin commented Sep 10, 2014

Most of the code is taken from here: https://code.google.com/p/audiostreamer-meta/

@anhar
Copy link

anhar commented Oct 20, 2014

I have just cloned @tgrbin forked repository and can verify that this works. The company I'm working for is currently using Icecast for audio streams. When receiving ad metadata, the streamTitle and streamUrl parameters are sometimes empty but I get all the custom parameters. Please merge this one. And thank you @tgrbin for the pull request.

@secretfader
Copy link

This would be a great addition to the library. Like others, I'm using StreamingKit to playback audio from Icecast, and would appreciate SK eliminating the need for a custom metadata parser.

@syrakozz
Copy link

syrakozz commented Jan 5, 2015

+1

@secretfader
Copy link

@tumtumtum If there isn't interest in merging this change into core, cool. Would you be willing to point anyone in this thread to an example of extracting metadata from the datastream already pulled in by SK? IMO, that would be even better than this PR.

@tumtumtum
Copy link
Owner

Sorry I forgot this PR existed when I added shoutcast streaming support to HTTPDataSource. Won't take long to add metadata support to the existing datasource. If I find time this weekend...

@syrakozz
Copy link

syrakozz commented Jan 8, 2015

thank you this project is fantastic


Sent from Mailbox

On Thu, Jan 8, 2015 at 12:41 PM, Thong Nguyen [email protected]
wrote:

Sorry I forgot this PR existed when I added shoutcast streaming support to HTTPDataSource. Won't take long to add metadata support to the existing datasource. If I find time this weekend...

Reply to this email directly or view it on GitHub:
#131 (comment)

@secretfader
Copy link

@tumtumtum Cool. I take it that you'll be supporting any metadata, and not just StreamTitle, correct? (Because Icecast supports any metadata in key=value format. And being able to send additional data, like album=Album Title, would be very handy for my use case.)

@secretfader
Copy link

Any updates on this, @tumtumtum?

@syrakozz
Copy link

ping

@hummerpj
Copy link

Any plans on adding this feature or something similar? I like how the metadata and the updating is available via a delegate method.

Or is there a different way to expose access to this in a different way so people can write their own add-ons?

@secretfader
Copy link

FYI: AVPlayer supports reading Icecast Metadata by default, at least in iOS 8.1. I ended up using Reachability + AVPlayer for our app, and it's working pretty well so far.

StreamingKit might well be a better option, but this is a fix that you could use for now.

@s-chaudhary-2015
Copy link

Hey Guys! How can we stream video files (on iOS devices or websites) stored in a parse database? Can I use the same kit (from tumtumtum) to play video files instead of audio files? I would appreciate your reply on this. Thanks!

@secretfader
Copy link

@s-chaudhary-2015 I would look into AVPlayer since it has built in video controls. I doubt that StreamingKit would be of much help.

@diegostamigni diegostamigni self-requested a review March 19, 2019 11:33
@diegostamigni diegostamigni self-assigned this Mar 19, 2019
@diegostamigni
Copy link
Collaborator

I know this is very old with merge conflicts to be resolved first, but what is your plan on this feature @tumtumtum?

@tumtumtum
Copy link
Owner

Currently the master STKHttpDataSource has support for ICEcast metadata already but it doesn't expose the metadata as extensively as this PR? Maybe you can look and see if this PR is still useful @diegostamigni.

@diegostamigni
Copy link
Collaborator

Currently the master STKHttpDataSource has support for ICEcast metadata already but it doesn't expose the metadata as extensively as this PR? Maybe you can look and see if this PR is still useful @diegostamigni.

Yep I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants