Rwc2023 challenge serve breakfast #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PetervDooren
commented
Jul 25, 2023
|
I don't think we should re-tune this for Impuls, rather move to a better method. |
PetervDooren
force-pushed
the
rwc2023_challenge_serve_breakfast
branch
from
d3955f9 to
e7b5e50
Compare
shanki98
reviewed
Jul 25, 2023
| robot.base.force_drive(0, 0, vyaw, PICK_ROTATION / vyaw) | ||
| arm.gripper.send_goal("close", timeout=0.0) | ||
|
|
||
| # Look to the operator |
There was a problem hiding this comment.
Look at the operator standing to the right of the robot!
shanki98
reviewed
Jul 25, 2023
challenge_serve_breakfast/src/challenge_serve_breakfast/navigate_to_and_place_item_on_table.py
Show resolved
Hide resolved
shanki98
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1325 keeps track of the issues that are still in the code. I suggest to first merge the rwc2023 version and then make smaller PRs to fix these smaller issues.