Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Find_people_in_room and Find_person_in_room #891

Open
PetervDooren opened this issue Sep 10, 2019 · 1 comment
Open

Merge Find_people_in_room and Find_person_in_room #891

PetervDooren opened this issue Sep 10, 2019 · 1 comment
Labels
maintenance Making existing code better in terms of style and setup

Comments

@PetervDooren
Copy link
Contributor

We currently have two smach states dedicated to finding people.

find_person_in_room.py: which uses faces and ed entities.
Find_people_in_room.py: which uses the people detector.

Merging these two files will break a lot of things in the action server and smach states.
@PetervDooren PetervDooren mentioned this issue Sep 11, 2019
Merged
@PetervDooren PetervDooren mentioned this issue Sep 20, 2019
Closed
34 tasks
@MatthijsBurgh
Copy link
Member

Don't forget to check UpdateDestEntityPoseWithSrcEntity in world_model.py

@PetervDooren PetervDooren added the maintenance Making existing code better in terms of style and setup label Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Making existing code better in terms of style and setup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatthijsBurgh @PetervDooren