-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add qr_code_decoder to launchfile #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
MatthijsBurgh
previously approved these changes
Mar 19, 2024
MatthijsBurgh
previously approved these changes
Apr 30, 2024
MatthijsBurgh
approved these changes
May 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash this PR
MatthijsBurgh
added a commit
to tue-robotics/hmi
that referenced
this pull request
May 14, 2024
**After merge, merge also [robot launch files PR](tue-robotics/robot_launch_files#80) and [hero_bringup PR](tue-robotics/hero_bringup#149 Adds QR code reading functionality to hero as a wrapper for an HMI server. Aimed for GPSR and EGPSR. ToDo: - [x] Remove hardcoded 'hero' from topic list - [x] Read qr code x times to verify the data - [x] Check how much of the screen the qr code takes up (to not have false positives) - [x] Add maximum tries - [x] Add pyzbar to the dependencies - [x] Add to lauchfile
MatthijsBurgh
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after HMI qr_code_decoder PR