Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/battery warning msi laptop #45

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

KevinDang74
Copy link
Contributor

No description provided.

src/battery_manager_laptop.cpp Outdated Show resolved Hide resolved
src/battery_manager_laptop.cpp Outdated Show resolved Hide resolved
src/battery_manager_laptop.cpp Show resolved Hide resolved
}

// publish voice message
if (old_message != message && message != "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have indeed :-)

Can also be part of the callback though AFAIK

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We would want to check whether the percentage has changed rather than the message

src/battery_manager_laptop.cpp Outdated Show resolved Hide resolved
Copy link
Member

@LoyVanBeek LoyVanBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting there :-)

src/battery_manager_laptop.cpp Outdated Show resolved Hide resolved
src/battery_manager_laptop.cpp Outdated Show resolved Hide resolved
launch/hero_bringup.launch Outdated Show resolved Hide resolved
src/battery_manager_laptop.cpp Outdated Show resolved Hide resolved
MatthijsBurgh
MatthijsBurgh previously approved these changes Mar 7, 2020
@MatthijsBurgh
Copy link
Member

@PetervDooren can you test this and merge it?

@PetervDooren
Copy link
Contributor

Tested on the robot. After this last commit it works

Copy link
Member

@MatthijsBurgh MatthijsBurgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like the launch file rename to battery_manager_hero2.launch

MatthijsBurgh
MatthijsBurgh previously approved these changes Mar 7, 2020
Copy link
Member

@MatthijsBurgh MatthijsBurgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test before merging

ros::param::get("/robot_location", robot_location);

ros::Subscriber battery_sub = gn.subscribe("battery", 1, batteryCallback);
speech_pub = gn.advertise<std_msgs::String>("text_to_speech/input", 10);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This speech publisher goes to the text to speech bridge node. Please either:

  • publish directly to the toyota interface (my preference)
  • launch the speech bridge along with the battery manager

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I publish directly to the toyota interface? What is the topic name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/battery_manager_laptop.cpp Show resolved Hide resolved
}

// publish voice message
if (old_message != message && message != "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We would want to check whether the percentage has changed rather than the message

@PetervDooren
Copy link
Contributor

@KevinDang74 Installation process on hero2 is taken care of. I still have some changes I would like to see so I'm passing it back to you

Copy link
Member

@MatthijsBurgh MatthijsBurgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in this package. As it is only used on the robot and not in simulation

@MatthijsBurgh MatthijsBurgh force-pushed the feature/battery_warning_msi_laptop branch from 1b3ad51 to d807f5f Compare March 12, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants