Skip to content

Commit

Permalink
build(deps-dev): bump electron from 28.2.0 to 29.0.0 (#754)
Browse files Browse the repository at this point in the history
* build(deps-dev): bump electron from 28.2.0 to 29.0.0

Bumps [electron](https://github.com/electron/electron) from 28.2.0 to 29.0.0.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v28.2.0...v29.0.0)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* (test) accept window width of 1023-1024

* (test) accept window height of 599-600

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Matthijs van der Burgh <[email protected]>
  • Loading branch information
dependabot[bot] and MatthijsBurgh authored Feb 20, 2024
1 parent 04ec254 commit 34f582f
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 18 deletions.
46 changes: 31 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@vue/cli-plugin-eslint": "~5.0.1",
"@vue/cli-service": "~5.0.8",
"@vue/eslint-config-standard": "^8.0.1",
"electron": "^28.2.0",
"electron": "^29.0.0",
"electron-devtools-installer": "^3.2.0",
"electron-icon-builder": "^2.0.1",
"eslint": "^8.56.0",
Expand Down
6 changes: 4 additions & 2 deletions tests/electron.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ test.describe('Window Loads Properly', async () => {

test('Window bounds are correct', async () => {
const { height, width } = await browserWindow.evaluate((browserWindow) => { return { ...browserWindow.getBounds() } })
expect(width).toBe(1024)
expect(height).toBe(600)
expect(width).toBeGreaterThanOrEqual(1023)
expect(width).toBeLessThanOrEqual(1024)
expect(height).toBeGreaterThanOrEqual(599)
expect(height).toBeLessThanOrEqual(600)
})

test('Window title is correct', async () => {
Expand Down

0 comments on commit 34f582f

Please sign in to comment.