-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ros2 #38
base: master
Are you sure you want to change the base?
Ros2 #38
Changes from 15 commits
6242ee2
35d70a9
af6dbbf
9e950e3
8480d3c
e8eaf9c
64efc41
3604a2e
f7fa7ba
2049185
5d6e159
f413ba0
01d7ecc
4bd4483
966fee9
4385e47
254bf97
2d3b3ba
bf373dc
cd962f0
d674459
ec7663b
141123f
0d0e359
3c6bf56
b90ad1c
04d1e6b
c64ea07
32e9fad
3863ae4
a973357
9c20c6c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
#ifndef EMC_SYSTEM_RATE_H_ | ||
#define EMC_SYSTEM_RATE_H_ | ||
|
||
namespace ros | ||
#include "rclcpp/rclcpp.hpp" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should include this in the source file. That is why the pre-declaration was there. |
||
#include <rclcpp/logger.hpp> | ||
|
||
/*namespace rclcpp | ||
{ | ||
class Rate; | ||
class GenericRate; | ||
} | ||
|
||
*/ | ||
namespace emc | ||
{ | ||
|
||
|
@@ -22,8 +25,8 @@ class Rate | |
|
||
private: | ||
|
||
ros::Rate* rate_; | ||
|
||
rclcpp::GenericRate<std::chrono::system_clock>* rate_; | ||
//rclcpp::Logger logger_; | ||
}; | ||
|
||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<?xml version="1.0"?> | ||
<?xml version="2.0"?> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is no XML version 2... |
||
<?xml-model | ||
href="http://download.ros.org/schema/package_format3.xsd" | ||
schematypens="http://www.w3.org/2001/XMLSchema"?> | ||
|
@@ -11,19 +11,25 @@ | |
|
||
<license>TODO</license> | ||
|
||
<buildtool_depend>catkin</buildtool_depend> | ||
<buildtool_depend>rosidl_default_generators</buildtool_depend> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is only needed when generating message, etc. Though you should have a buildtool dep on |
||
|
||
<depend>geometry_msgs</depend> | ||
<depend>nav_msgs</depend> | ||
<depend>roscpp</depend> | ||
<depend>rclcpp</depend> | ||
<depend>sensor_msgs</depend> | ||
<depend>visualization_msgs</depend> | ||
<depend>tf2</depend> | ||
<depend>tf2_ros</depend> | ||
|
||
<exec_depend>rosidl_default_runtime</exec_depend> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also not needed as we are not generating messages etc. |
||
|
||
<doc_depend>doxygen</doc_depend> | ||
|
||
<test_depend>ament_cmake_gtest</test_depend> | ||
|
||
<export> | ||
<rosdoc config="rosdoc.yaml" /> | ||
<build_type>ament_cmake</build_type> | ||
</export> | ||
|
||
</package> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come on @PetervDooren, you can migrate tests as well. You have the skills