Skip to content

Commit

Permalink
prep assignments
Browse files Browse the repository at this point in the history
  • Loading branch information
@KdVos
KdVos committed Feb 16, 2023
1 parent 7a04f6c commit 05f562d
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions setup/emc-update-impl.bash
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,11 @@ fi
sudo cp "$EMC_SYSTEM_DIR"/devel/lib/libemc_system.so /usr/lib/libemc-framework.so
sudo cp "$EMC_SYSTEM_DIR"/src/emc_system/include/emc /usr/include/ -r

# 6) Install gtest for localization assignments
_make_sure_installed libgtest-dev
cd /usr/src/gtest

This comment has been minimized.

Sign in to view

Copy link
@MatthijsBurgh

MatthijsBurgh Feb 16, 2023

Member

Why would you need to build something which is installed by apt-get?

This comment has been minimized.

Sign in to view

Copy link
@KdVos

KdVos Feb 16, 2023

Author Contributor

Because libgtest-dev only install source files, which aren't build yet.....
doesn't have my preference either but don't see a neat way around it

This comment has been minimized.

Sign in to view

Copy link
@MatthijsBurgh

MatthijsBurgh Feb 16, 2023 •
edited
Loading

Member

It seems to be build, see https://packages.ubuntu.com/focal/amd64/libgtest-dev/filelist

/usr/lib/x86_64-linux-gnu/libgtest.a
/usr/lib/x86_64-linux-gnu/libgtest_main.a

You are just looking in the wrong place. So are you sure CMake can't find these by find_package or else by PkgConfig?

This comment has been minimized.

Sign in to view

Copy link
@KdVos

KdVos Feb 16, 2023

Author Contributor

Ok great, however the issue remains for the rosbots, which run 18.04

https://packages.ubuntu.com/bionic/amd64/libgtest-dev/filelist

right?

However, we can probably make sure the tests aren't build in that case

This comment has been minimized.

Sign in to view

Copy link
@MatthijsBurgh

MatthijsBurgh Feb 16, 2023

Member

Ok, you will need to solve that separately. But that pkg doesn't contain any file to build.

It does depend on googletest, but that doesn't seem to have files in /usr/src/gtest

This comment has been minimized.

Sign in to view

Copy link
@MatthijsBurgh

MatthijsBurgh Feb 16, 2023

Member

Yes, when your CMake is correct, you should be able to disable tests.
sudo cmake CMakeLists.txt
sudo make
sudo cp ./lib/libgtest*.a /usr/lib

trap - ERR

0 comments on commit 05f562d

Please sign in to comment.