Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spr knowledge dependency #114

Open
LarsJanssenTUe opened this issue May 22, 2019 · 1 comment
Open

Remove spr knowledge dependency #114

LarsJanssenTUe opened this issue May 22, 2019 · 1 comment

Comments

@LarsJanssenTUe
Copy link
Contributor

In answer_question.py:

        #To do: remove this dependency!
        self._speech_data = load_knowledge('challenge_spr')
        if not self._speech_data:
            rospy.logerr("Failed to load speech data for 'AnswerQuestion' action")
            return
@LarsJanssenTUe LarsJanssenTUe mentioned this issue May 22, 2019
@LarsJanssenTUe
Copy link
Contributor Author

After discussion with @MatthijsBurgh it is decided that this specific knowledge should be transferred to the common knowledge, but we do not know what to do with the issue itself that knowledge is being loaded here without checking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant