feat: Add C++ Mmap Wrapper #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmario
requested changes
Aug 16, 2024
cvonelm
force-pushed
the
introduc_shmem_class
branch
from
d43b469
to
9bc22aa
Compare
bmario
requested changes
Aug 19, 2024
cvonelm
force-pushed
the
introduc_shmem_class
branch
2 times, most recently
from
f7be674
to
d90a155
Compare
bmario
requested changes
Aug 20, 2024
include/lo2s/shared_memory.hpp
Outdated
|
|
||
| ~SharedMemory() | ||
| { | ||
| if (addr_ != nullptr) |
include/lo2s/shared_memory.hpp
Outdated
Comment on lines
56
to
59
| if (addr_ != nullptr) | ||
| { | ||
| munmap(addr_, size_); | ||
| } |
There was a problem hiding this comment.
extract into function and use in desctructor
In preperation for CUPTI support, this commit adds a SharedMemory class that wraps Mmap and converts the EventReader to use it.
cvonelm
force-pushed
the
introduc_shmem_class
branch
from
d90a155
to
fc4898f
Compare
bmario
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preperation for CUPTI support, this commit adds a SharedMemory class that wraps Mmap and converts the EventReader to use it.