Turn EventDescription into class #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teto519f
force-pushed
the
issue-224-EventDescription-into-class
branch
from
36ca29e
to
e66d04a
Compare
cvonelm
reviewed
Jul 23, 2024
cvonelm
reviewed
Jul 26, 2024
bmario
requested changes
Jul 26, 2024
teto519f
force-pushed
the
issue-224-EventDescription-into-class
branch
3 times, most recently
from
6e7e736
to
820daaa
Compare
cvonelm
reviewed
Aug 8, 2024
bmario
requested changes
Aug 22, 2024
teto519f
force-pushed
the
issue-224-EventDescription-into-class
branch
4 times, most recently
from
3601ca0
to
7798068
Compare
bmario
approved these changes
Nov 14, 2024
added 15 commits
November 14, 2024 12:18
added 13 commits
November 14, 2024 12:23
teto519f
force-pushed
the
issue-224-EventDescription-into-class
branch
from
b87b684
to
a04153f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #224
This PR creates a PerfEvent and a PerfEventInstance class, which can handle every type of event in lo2s. It aims to remove redundant code for event creation and to simplify their handling.