Update request title #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For some reason, we could end up in a state where a request's status is "resubmitted" in the database while it is `accepted` in opensearch.
max-moser
approved these changes
Oct 7, 2024
| @@ -68,9 +68,25 @@ def delete_draft(self, identity, draft=None, record=None, force=False): | |||
| # Delete draft for a published record. | |||
| # Since only one request per record should exist, it is not deleted. Instead, put it back to accepted. | |||
| current_requests_service.execute_action( | |||
| system_identity, request["id"], "cancel" | |||
| system_identity, request["id"], "cancel", uow=self.uow | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the curation request title, whenever the title of the draft changes (closes #27)
When a draft is deleted, a curation review is fetched. Since we would completely serialize this review and generate links, we would also try to resolve the topic of the review - which is a draft. However, when deleting a draft, it will be set to deleted before running the components. This will lead to a
PIDDoesNotExistErrorin the generator. Such an exception will now be caught and an empty set will be returned instead of trying to read the permissions of the entity.Pass uow to service calls. For some reason, we could end up in a state where a request's status is "resubmitted" in the database while it is
acceptedin opensearch. This lead to the request being displayed correctly on the request detail page (request read from database) but incorrectly on the record deposit page (request read from opensearch). Since when running the component, it is also read from opensearch, this would lead to the issue of trying to execute the requestresubmitaction on draft changes, even though it was already inresubmittedstate.