Added examples/core_2d_camera_platformer and core_2d_camera.c #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IRooc
force-pushed
the
example/2d_platformer
branch
from
1a7fcde
to
00aa97c
Compare
IRooc
changed the title
IRooc
changed the title
IRooc
changed the title
IRooc
force-pushed
the
example/2d_platformer
branch
from
9ff2ab1
to
e15285d
Compare
RobLoach
reviewed
Feb 27, 2024
RobLoach
reviewed
Feb 27, 2024
| const color = getColorFromMemory(buffer, color_ptr); | ||
| [startX, startY] = this.applyCameraOffset(startX, startY); | ||
| [endX, endY] = this.applyCameraOffset(endX, endY); | ||
| this.ctx.beginPath(); |
There was a problem hiding this comment.
Nice work on the camera offset. I've implemented a few of these basic shape drawing functions in #53 .
Co-authored-by: Rob Loach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic setup works But the zoom feature didn't work.
If you want I can remove the nob.c changes because I build on windows I had to change it, just let me know.
Because every draw call now has to go through the Camera2D check this touches a lot of calls in a small way.