Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url bibtex to support opened in Brave Browser #428

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yasirroni
Copy link

The old link in http://jmlr.org/papers/v21/20-091.html seems to be dead and moved to https://www.jmlr.org/papers/v21/20-091.html

@rtavenar
Copy link
Member

On my side, both links work...

@yasirroni
Copy link
Author

yasirroni commented Oct 11, 2022

Ah, I see.

I was previously tested the link in brave. Tested in chrome, the older link works.

I don't think brave strictly only allow HTTPS because AFAIK, it will only warn user when going to HTTP.
_
Tested in brave, it return

Check your Internet connection
Check any cables and reboot any routers, modems or other network devices you may be using.

_
I don't know the cause. If you accept this PR, than it will support both browser. If this PR is rejected, I'm okay with it since the old link works on certain browser.

@yasirroni
Copy link
Author

I test brave to open HTTP (http://example.com/) and it works.

Then, it might not be because brave didn't support HTTP, but the old link might has other issue.

@yasirroni yasirroni changed the title Fix url bibtex Fix url bibtex to support opened in Brave Browser Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants