Suggestion for vignette: a spatial simulation #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggesting geographic distance to use only the first two entries of locs, in case the third entries are not all equal to each other.
|
OMG good catch. (And I somehow just noticed these PRs.) |
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage 95.65% 95.65%
=======================================
Files 8 8
Lines 621 621
Branches 131 131
=======================================
Hits 594 594
Misses 18 18
Partials 9 9 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, thank you for a helpful vignette on spatial simulations! I saw that the third entry of the location list is included when calculating the geographic distance. May I suggest using only the first two entries, since the example is in a two dimensional space?