Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): update verify workflow to use dcm for analysis #242

Merged
merged 7 commits into from
Oct 22, 2024
Merged

chore(ci): update verify workflow to use dcm for analysis #242

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0198c7a
chore(ci): update verify workflow to use dcm for analysis
tsinis Oct 22, 2024
44041d2
fix: update hero tag in example's fab
tsinis Oct 22, 2024
b5fffe1
fix: update print statements for clarity in currencies example
tsinis Oct 22, 2024
bc78578
fix(ci): adjust permissions for build directory in verify workflow
tsinis Oct 22, 2024
ca4d374
fix(ci): update permissions setup for build directory in verify workflow
tsinis Oct 22, 2024
0dacaea
fix(ci): increase minimum pub points requirement in verify workflow
tsinis Oct 22, 2024
a28cd26
fix(ci): enhance dcm analysis with additional flags
tsinis Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/verify_package_workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,18 @@ jobs:
report: ${{ steps.analysis.outputs.json_output }}
min-pub-points: 130

- name: 🛂 Set up file system write permissions
run: sudo chown -R runner:runner $(pwd) && sudo chmod -R 777 $(pwd)
- name: 📥 Install DCM
if: ${{ github.event_name == 'pull_request' }}
uses: CQLabs/[email protected]
with:
github_token: ${{ secrets.GITHUB_TOKEN }}

- name: 🔎 Dart Code Metrics
if: ${{ github.event_name == 'pull_request' }}
run: dart run dart_code_linter:metrics --fatal-style --fatal-performance --fatal-warnings -r github lib
run: dcm analyze .
tsinis marked this conversation as resolved.
Show resolved Hide resolved

- name: 🛂 Set up file system write permissions
run: sudo chown -R runner:runner $(pwd) && sudo chmod -R 777 $(pwd)

- name: 🧪 Run Dart tests
if: ${{ !inputs.is_flutter }}
Expand Down
6 changes: 3 additions & 3 deletions packages/sealed_currencies/example/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ void main() {
subunitToUnit: 100, unitFirst: true), translations: eurCurrencyTranslations".
*/

print(isVikingKrone(const FiatNok())); // Prints "true".
print(isVikingKrone(serbianDinar)); // Prints "null".
print(isVikingKrone(const FiatCzk())); // Prints "false".
print(isVikingKrone(const FiatNok())); // Prints true.
print(isVikingKrone(serbianDinar)); // Prints null.
print(isVikingKrone(const FiatCzk())); // Prints false.

FiatCurrency.list
.where((currency) => currency.symbol?.contains("kr") ?? false)
Expand Down
2 changes: 1 addition & 1 deletion packages/world_countries/example/lib/widgets/floating_button.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class FloatingButton extends StatelessWidget {
onLongPress: () => onPressed(isLong: true),
// ignore: prefer-action-button-tooltip, we need long-press here.
child: FloatingActionButton(
heroTag: "fab",
heroTag: "FAB",
onPressed: () => onPressed(isLong: false),
child: AnimatedBuilder(
animation: controller,
Expand Down
Loading