Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lint): added new lints and dcm #228

Merged
merged 23 commits into from
Oct 13, 2024
Merged

refactor(lint): added new lints and dcm #228

merged 23 commits into from
Oct 13, 2024

Conversation

tsinis
Copy link
Owner

@tsinis tsinis commented Oct 13, 2024

Description

Massive refactoring related to the DCM and regular lints also covers some tech-dept topics.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • 🧪 Tests
  • 📝 Documentation
  • ⚙️ CI/CD or GitHub Workflow configuration change
  • 📦 Dependencies update

Checks

Please look at the following checklist to ensure that your PR can be accepted quickly:

  • Data come from open-source resources with MIT License (if presented).
  • New code is documented and the data source is referenced (if presented).
  • Existing tests are up to date with these changes.
  • New code is fully tested (if presented).

github-actions[bot]
github-actions bot previously approved these changes Oct 13, 2024
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 99.60784% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.96%. Comparing base (c602622) to head (dd426d5).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...countries/lib/src/helpers/functional_platform.dart 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   99.54%   99.96%   +0.42%     
==========================================
  Files          45      205     +160     
  Lines        1106    16585   +15479     
==========================================
+ Hits         1101    16580   +15479     
  Misses          5        5              
Flag Coverage Δ
sealed_countries 100.00% <100.00%> (?)
sealed_currencies 100.00% <100.00%> (?)
sealed_languages 100.00% <100.00%> (?)
world_countries 99.64% <98.76%> (+0.09%) ⬆️
world_flags 99.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions[bot]
github-actions bot previously approved these changes Oct 13, 2024
github-actions[bot]
github-actions bot previously approved these changes Oct 13, 2024
@tsinis tsinis merged commit 848bcdb into main Oct 13, 2024
19 of 20 checks passed
@tsinis tsinis deleted the refactor/lints-update branch October 13, 2024 22:38
@tsinis tsinis restored the refactor/lints-update branch October 14, 2024 07:40
@tsinis
Copy link
Owner Author

tsinis commented Oct 14, 2024

@coderabbitai full review

Copy link

coderabbitai bot commented Oct 14, 2024

✅ Actions performed

Full review triggered.

@tsinis
Copy link
Owner Author

tsinis commented Oct 14, 2024

@coderabbitai review

Copy link

coderabbitai bot commented Oct 14, 2024

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@tsinis tsinis deleted the refactor/lints-update branch October 14, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant