-t option for headers with molten #48
Conversation
main.c
Outdated
| @@ -57,8 +58,8 @@ void show_help(int retcode) | |||
| int main(int argc, char* argv[]) | |||
| { | |||
| // parse command line parameters | |||
| int opt, quiet = 0, csv = 0, corner = 1, allchars = 0, keepcase = 0, molten = 0; | |||
| while ((opt = getopt(argc, argv, "hj:qcakmbv")) != -1) { | |||
| int opt, quiet = 0, csv = 0, corner = 1, allchars = 0, keepcase = 0, moltenheader = 0, molten = 0; | |||
There was a problem hiding this comment.
Looks like an autoindentation error here.
There was a problem hiding this comment.
Hi Fabian, thanks for the review. I double checked my changes and fixed the auto-indentation by using 2 space indentation, as it appears to be the convention for this repo. Please let me know if any other changes are found to be necessary.
|
Hi @kloetzl, let me know if any other changes should be made for this PR, thanks! |
|
I leave it to Thorsten to make the call whether to merge this. I'm only wondering if |
|
Thanks for the feedback, I appreciate it! I wasn't entirely sure which option would be best since |
|
I agree, a header is nice, but is also easy to add one via standard unix tools: |
|
Fair enough! If you and Torsten feel that it's not necessary then I can close the PR. |
If that is the impression you got I need to apologize. I would have merged this pull request almost straight away, I just don't have the permissions to do it. We need to wait for @tseemann to do that. |
No problem at all @kloetzl! I know that it's a very trivial PR so I understand that there is no specific need to merge this in now. |
I thought it may be useful to have the option for the output/output file generated with molten format to be able to have column headers. I use snp-dists in COVID-19 analysis pipelines and often use the snp-dists molten output to filter for sample subsets based on SNP distance. Having defined column headers may make it easier to read in and filter these molten outputs.
The column headers can be added with '-t' when '-m' is also enabled.
Let me know if the PR is not appreciated, thanks for the tool!