checking post run alerts properties presence (krkn-chaos#584)

added metric check Signed-off-by: Tullio Sebastiani <[email protected]>
tsebastiani · Mar 1, 2024 · b9c0bb3 · b9c0bb3
1 parent 706a886
commit b9c0bb3
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/kraken/prometheus/client.py b/kraken/prometheus/client.py
@@ -66,8 +66,13 @@ def critical_alerts(prom_cli: KrknPrometheus,
     )
 
     for alert in post_critical_alerts:
-        alert = ChaosRunAlert(alert["metric"]["alertname"], alert["metric"]["alertstate"], alert["metric"]["namespace"], alert["metric"]["severity"])
-        summary.post_chaos_alerts.append(alert)
+        if "metric" in alert:
+            alertname = alert["metric"]["alertname"] if "alertname" in alert["metric"] else "none"
+            alertstate = alert["metric"]["alertstate"] if "alertstate" in alert["metric"] else "none"
+            namespace = alert["metric"]["namespace"] if "namespace" in alert["metric"] else "none"
+            severity = alert["metric"]["severity"] if "severity" in alert["metric"] else "none"
+            alert = ChaosRunAlert(alertname, alertstate, namespace, severity)
+            summary.post_chaos_alerts.append(alert)
 
     during_critical_alerts_count = len(during_critical_alerts)
     post_critical_alerts_count = len(post_critical_alerts)