Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add datasheet URL support for snippets #380

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Implements #345

Changes:

  • Added datasheet_url field to snippet schema
  • Created EditDatasheetUrlDialog component for managing URLs
  • Added datasheet URL display and editing to ViewSnippetSidebar
  • Added tests for datasheet URL functionality
  • Fixed TypeScript errors in dialog implementation

Link to Devin run: https://app.devin.ai/sessions/fd4f2b9d4eb248a6adec403ed7a5032a

devin-ai-integration bot and others added 4 commits December 13, 2024 03:30
- Add datasheet_url field to snippet schema
- Create EditDatasheetUrlDialog component
- Add datasheet URL editing to ViewSnippetSidebar

Co-Authored-By: Severin Ibarluzea <[email protected]>
- Add datasheet URL display with View/Edit buttons
- Add Add Datasheet URL button when no URL exists
- Integrate EditDatasheetUrlDialog component
- Follow existing UI patterns and styling

Co-Authored-By: Severin Ibarluzea <[email protected]>
- Add test case for updating snippet datasheet URL
- Verify API response and database update
- Follow existing test patterns

Co-Authored-By: Severin Ibarluzea <[email protected]>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a playwright test that updates the datasheet url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant