fix: improve popup default styles #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschoffelen
approved these changes
Apr 17, 2024
|
@tschoffelen - Yep, I'm doing this in our app's customization. It should be used when react-native Modal's transparent prop is set to |
meteorlxy
force-pushed
the
meteorlxy/popup-style
branch
from
8894894 to
aba7432
Compare
|
@tschoffelen updated |
|
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm not sure if the current style is fully tested, but it does not work well in our app.
If this PR is not going to be merged, at least we should have #289 to allow user customizing the modalView style.
FYI, the example provided by react-native docs also does not restrict the height and background color of the container:
Screenshots