Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigating based on the address info as street, city, region and country #183

Closed
wants to merge 11 commits into from
Closed

Navigating based on the address info as street, city, region and country #183

wants to merge 11 commits into from

Conversation

LayssonOL
Copy link

  • Possible to search locations passing a formatted address ( dstaddr in options, be Popup or showLocation )

@tschoffelen
Copy link
Owner

Thanks for your contribution @LayssonOL.

I have one concern with your PR. By changing the prefixes from URL schemes to universal URLs, our detection mechanism won't work anymore (ie. https://maps.apple.com/ can always be opened, even if the Apple Maps app isn't installed).

@tschoffelen
Copy link
Owner

Thanks for your contributions, and apologies for the massive delay.

I think a similar PR is open here: #272, so I'm going to close this for now. My apologies again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LayssonOL @tschoffelen