-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexible logging #160
base: debug
Are you sure you want to change the base?
Conversation
@loop8ack Thank you for the suggestion. Agreed that the internal logging on the .NET side was thrown in hastily. We would like to implement Microsoft.Extensions.Logging and Microsoft.Extensions.DependencyInjection.Abstractions, but it's not at the top of our priority list. Since all logging calls within Photino.NET are private, and likely should remain private, we shouldn't have to worry about breaking changes. We'll just have to make sure that if no logger is specified, we default to a console logger. Thoughts? |
@MikeYeager The concern about BreakingChanges relates to the "LogVerbosity" property, as this is public and follows a concept that differs from the standard. The same applies to the "SetLogVerbosity" method. If I use Microsoft.Extensions.Logging, the old LogVerbosity concept would be dropped, which leads to problems if someone has customized the LogVerbosity. I guess that wouldn't be very bad, but I still wanted to get feedback first. |
Is there any news on this? If necessary, I can also create a new pull request with Microsoft.Extensions.Logging. |
We are currently working on updating and bugfixing our Samples projects. When we get to incorporating new features, we will circle back to this and incorporate it on the next major release. |
Implemented a custom logger interface in Photino.NET to provide flexible logging solutions. This extension should be backward compatible.
I plan to develop an integration of Microsoft.Extensions.Logging within the
photino.Blazor
project:Suggestion for Future Consideration
As an alternative improvement, integrating Microsoft.Extensions.Logging.Abstractions could be considered for future enhancements. This integration would necessitate breaking changes, such as the removal of the
LogVerbosity
property andSetLogVerbosity()
method. It's also important to note that this integration would introduce an additional dependency on Microsoft.Extensions.DependencyInjection.Abstractions.Despite this, it offers a more unified and standardized approach to logging.
If an integration of "Microsoft.Extensions.Logging" is under consideration, then please feel free to view this pull request as an invitation for discussion.