Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows users to edit History #35

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Allows users to edit History #35

merged 1 commit into from
Aug 16, 2024

Conversation

thnak
Copy link
Contributor

@thnak thnak commented Aug 16, 2024

Thanks for your best!
For some reason, we have to end the chat session and then come back and continue that chat session. so I think we need this

Summary by CodeRabbit

  • New Features
    • Enhanced the chat functionality by allowing users to modify the message history directly, enabling better interaction and management of chat messages.

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

coderabbitai bot commented Aug 16, 2024

Walkthrough

The recent update to the Chat class enhances its functionality by modifying the History property. Previously read-only, the History property can now be both retrieved and modified. This change allows external code to dynamically manage the chat history, enabling a more interactive user experience as messages can be added or removed after the chat instance is created.

Changes

Files Change Summary
src/libs/Ollama/Chat.cs History property changed from public List<Message> History { get; } to public List<Message> History { get; set; }

Poem

In the garden where chats unfold,
A property changed, a story told.
With setters now, messages flow,
A lively history, watch it grow!
Hopping with joy, a rabbit’s delight,
In the world of code, all feels just right! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@HavenDV HavenDV enabled auto-merge (rebase) August 16, 2024 09:34
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
src/libs/Ollama/Chat.cs (1)

13-13: Consider thread safety and encapsulation for History.

Making History read-write allows external modifications, which could lead to data integrity issues or race conditions in concurrent scenarios. Consider using a method to modify History to maintain control over changes and ensure thread safety, possibly using synchronization mechanisms like locks.

private readonly object _historyLock = new object();

public void AddToHistory(Message message)
{
	lock (_historyLock)
	{
		History.Add(message);
	}
}
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 439f23c and 76b597f.

Files selected for processing (1)
  • src/libs/Ollama/Chat.cs (1 hunks)

@HavenDV HavenDV merged commit 4066bab into tryAGI:main Aug 16, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants