-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
omitExtensionCreation is added to PostgresVectorDatabase.cs #33
Conversation
Since not all DB admins like to share SU roles to access applications.
Making sure that the parameter can be passed from the actual creation point.
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PostgresVectorDatabase
participant PostgresDbClient
User->>PostgresVectorDatabase: Create instance(connectionString, schema, omitExtensionCreation)
PostgresVectorDatabase->>PostgresDbClient: Initialize with connectionString, schema, omitExtensionCreation
PostgresDbClient-->>PostgresVectorDatabase: Client initialized
PostgresVectorDatabase-->>User: Instance created
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/Postgres/src/PostgresVectorDatabase.cs (2 hunks)
Additional context used
GitHub Check: Build and test / Build, test and publish
src/Postgres/src/PostgresVectorDatabase.cs
[failure] 15-15:
Syntax error, ',' expected
[failure] 15-15:
Syntax error, ',' expected
[failure] 15-15:
Syntax error, ',' expected
[failure] 15-15:
Syntax error, ',' expected
[failure] 15-15:
Syntax error, ',' expected
[failure] 15-15:
Syntax error, ',' expected
[failure] 15-15:
Syntax error, ',' expected
[failure] 15-15:
Syntax error, ',' expected
Additional comments not posted (2)
src/Postgres/src/PostgresVectorDatabase.cs (2)
21-21
: LGTM!The code changes are approved.
71-71
: LGTM!The code changes are approved.
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/Postgres/src/PostgresVectorDatabase.cs (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- src/Postgres/src/PostgresVectorDatabase.cs
In the Previous PR, I failed to add this.
Summary by CodeRabbit
New Features
Bug Fixes