Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra Decred signer tests and fixes #949

Merged
merged 11 commits into from
May 8, 2020
Merged

Extra Decred signer tests and fixes #949

merged 11 commits into from
May 8, 2020

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented May 8, 2020

Description

Extra tests for Decred signer for increased coverage.

Testing instructions

Unit tests.

Types of changes

  • Extra tests
  • Minor fixes

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description (e.g. 'Fixes Adopt Zilliqa to bech32 address format #444 ).

@optout21 optout21 requested a review from hewigovens as a code owner May 8, 2020 06:22
@hewigovens
Copy link
Contributor

forget to check in new added files?

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #949 into master will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
+ Coverage   93.49%   93.77%   +0.27%     
==========================================
  Files         425      425              
  Lines       12230    12213      -17     
==========================================
+ Hits        11435    11453      +18     
+ Misses        795      760      -35     
Impacted Files Coverage Δ
src/Bitcoin/TransactionSigner.h 100.00% <ø> (ø)
src/Decred/Signer.h 100.00% <ø> (ø)
src/Decred/TransactionBuilder.h 95.00% <ø> (-0.24%) ⬇️
src/Bitcoin/TransactionSigner.cpp 87.34% <100.00%> (+6.25%) ⬆️
src/Decred/Signer.cpp 70.96% <100.00%> (+14.62%) ⬆️
src/interface/TWBitcoinScript.cpp 96.42% <0.00%> (-3.58%) ⬇️
src/Bitcoin/Transaction.cpp 97.63% <0.00%> (-2.37%) ⬇️
src/Result.h 81.48% <0.00%> (+18.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61a114...3374d97. Read the comment docs.

@optout21 optout21 changed the title WIP Extra Decred signer tests and fixes Extra Decred signer tests and fixes May 8, 2020
@optout21 optout21 merged commit 870a192 into master May 8, 2020
@optout21 optout21 deleted the ar/decredsigner branch May 8, 2020 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt Zilliqa to bech32 address format
3 participants